Hotfix/1.7.37 #1399
Merged
Hotfix/1.7.37 #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new account type to support ADFS on prem scenarios
juan-arias
reviewed
Jul 17, 2024
| @@ -53,7 +56,8 @@ + (MSIDAccountType)accountTypeFromString:(NSString *)type | |||
|
|
|||
| sAccountTypes = @{@"aad": @(MSIDAccountTypeAADV1), | |||
| @"msa": @(MSIDAccountTypeMSA), | |||
| @"mssts": @(MSIDAccountTypeMSSTS)}; | |||
| @"mssts": @(MSIDAccountTypeMSSTS), | |||
| @"adfs": @(MSIDAccountTypeADFS)}; | |||
There was a problem hiding this comment.
nit: fix the identation
Suggested change
| @"adfs": @(MSIDAccountTypeADFS)}; | |
| @"adfs": @(MSIDAccountTypeADFS)}; |
kaisong1990
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request primarily involves the addition of a new account type,
MSIDAccountTypeADFS, to handle On-prem ADFS scenarios in the IdentityCore library. The changes are reflected in the enumerationMSIDAccountTypeand the associated account type handling methods. The changelog has also been updated to reflect this new feature.Here are the key changes:
IdentityCore/src/oauth2/account/MSIDAccountType.h: AddedMSIDAccountTypeADFSto theMSIDAccountTypeenumeration.IdentityCore/src/oauth2/account/MSIDAccountType.m: Updated theaccountTypeAsString:method to return "ADFS" when the account type isMSIDAccountTypeADFS.IdentityCore/src/oauth2/account/MSIDAccountType.m: Updated theaccountTypeFromString:method to map the string "adfs" toMSIDAccountTypeADFS.changelog.txt: Added a changelog entry for the new feature in version 1.7.37.Type of change
Risk
Additional information